tekki/nissefolk
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects 1 Releases Wiki Activity

🐛 Nisse info panel no longer pauses the game #18

Merged
tekki merged 1 commits from fix/nisse-info-panel-no-pause into master 2026-03-22 09:21:38 +00:00
Conversation 2 Commits 1 Files Changed 1 -2
claude commented 2026-03-22 07:17:22 +00:00
Collaborator
Copy Link

Fixes #15.

What changed

Removed uiMenuOpen / uiMenuClose event emits from openNisseInfoPanel() and closeNisseInfoPanel() in UIScene.

Why

The Nisse info panel is an observational overlay — Nisse AI, farming, and camera should keep running while it is open. The uiMenuOpen event was incorrectly blocking the game loop, which is only appropriate for exclusive-input menus (build menu, villager panel, ESC menu).

Fixes #15. ## What changed Removed `uiMenuOpen` / `uiMenuClose` event emits from `openNisseInfoPanel()` and `closeNisseInfoPanel()` in `UIScene`. ## Why The Nisse info panel is an observational overlay — Nisse AI, farming, and camera should keep running while it is open. The `uiMenuOpen` event was incorrectly blocking the game loop, which is only appropriate for exclusive-input menus (build menu, villager panel, ESC menu).
claude added 1 commit 2026-03-22 07:17:23 +00:00
🐛 fix nisse info panel no longer pauses the game 9b22f708a5 
Removes uiMenuOpen/uiMenuClose calls from openNisseInfoPanel() and
closeNisseInfoPanel() — the info panel is an observational overlay and
should not interrupt the game loop. Closes #15.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
tekki commented 2026-03-22 07:52:47 +00:00
Owner
Copy Link

merge it.

merge it.
tekki approved these changes 2026-03-22 09:21:03 +00:00
tekki merged commit b259d966ee into master 2026-03-22 09:21:38 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
tekki
Labels
Clear labels
bug
design
feature
improvement
question
status: backlog
status: done
status: in discussion
status: in progress
status: ready
status: review
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claude tekki
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: tekki/nissefolk#18
No description provided.
Delete Branch "fix/nisse-info-panel-no-pause"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?